25 Feb
2021
25 Feb
'21
9:07 p.m.
On Thu, 25 Feb 2021 14:31:42 -0500 Simon Glass sjg@chromium.org wrote:
We should not need CONFIG_DM here...it should be enabled for all boards. You can always disable MTD for a board if not, or send a removable patch.
If for some reason you do, please use if (IS_ENABLED() so that 'dev' can always be declared.
Simon, it still isn't enabled for all boards. For example tqma6s_wru4_mmc_defconfig does not compile with this. I actually wrote this into commit message:
Although CONFIG_DM is compulsory since v2020.01, there are still some boards (for example tqma6s_wru4_mmc_defconfig) that don't enable it.
But if breaking such boards is not a problem anymore, I will gladly just remove the ifdefs :) Should I?
Marek