On 11/11/2013 03:52 PM, Tom Rini wrote:
On Thu, Nov 07, 2013 at 02:23:32PM +0200, Roger Quadros wrote:
On 11/06/2013 11:48 PM, Tom Rini wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 11/06/2013 09:47 AM, Roger Quadros wrote:
Pipe3 PHY is used by SATA, USB3 and PCIe modules. This is a driver for the Pipe3 PHY.
Signed-off-by: Roger Quadros rogerq@ti.com
[snip]
+#define perror(fmt, args...) printf("%s: " fmt, __func__ , ##args)
Please use the debug macro.
But I want the message to be printed and not hidden if DEBUG is not defined.
Then just call printf please. Or is this kernel-adapted code?
OK. No this isn't in the kernel.
[snip[
- perror("%s: No DPLL configuration for %u Hz SYS CLK\n",
__func__, rate);Indent is wrong, we do like the kernel (and checkpatch.pl is in tools/ and will catch these). Thanks.
you mean the function arguments '__func__' and 'rate' should be on the same line where perror is?
perror("....\n", __func_, ...);
OK. I'll wait some more time for comments on v2 before I send out a v3 with these changes.
cheers, -roger