Re: [U-Boot] [PATCH] Adding support for DevKit8000

Frederik Kriewitz wrote:

This patch adds support for the DevKit8000 board.

Wolfgang commented already most of the topics.

So, only one comment left for me:

...

+++ b/board/omap3/devkit8000/devkit8000.c

...

+/*

• • Routine: misc_init_r
• • Description: Configure board specific parts
• */

+int misc_init_r(void) +{

...

• /* Use OMAP DIE_ID as MAC address */
• if (!eth_getenv_enetaddr("ethaddr", enetaddr)) {

• enetaddr[0] = 0x02; /* locally administered */
  

• enetaddr[1] = readl(&id_base->die_id_1) & 0xff;
  

• *(u32*)&enetaddr[2] = readl(&id_base->die_id_0);
  

• eth_setenv_enetaddr("ethaddr", enetaddr);
  

• }

With the OMAP DIE_ID thread we know what you are doing here. But do we want to have this really in mainline? It looks to me like a workaround for broken hardware (that is, having no proper MAC address configured)? Or do I miss anything?

Best regards

Dirk