Hi Alex,
On 28 August 2017 at 18:10, Alexander Graf agraf@suse.de wrote:
Am 26.08.2017 um 19:43 schrieb Simon Glass sjg@chromium.org:
This is currently disabled, so USB keyboards are not detected in U-Boot. Enable this option to fix that.
Signed-off-by: Simon Glass sjg@chromium.org Tested-by: Jonathan Gray jsg@jsg.id.au Reviewed-by: Bin Meng bmeng.cn@gmail.com Tested-by: Paul Barker pbarker@toganlabs.com
When did the default behavior on kbd usb support change? I'd be inclined to say that we should restore the exact same functionality scope as before for all affected boards, not just a few well tested ones ;).
In fact, wouldn't it make sense to imply usb kbd support in kconfig always when usb (and gfx?) is present?
Well I think it is odd to have to enable this option separately when you already have decided to use the keyboard. I'm not sure what to do in the interim, but once everything is using DM, we will drop CONFIG_DM_KEYBOARD. So this is really just an interim state.
I don't have strong views either way.
That said, this patch itself is good either way, just maybe not reaching far enough ;).
Alex
Regards, Simon