+CC: Graham Moore
On 11/07/2014 09:26 AM, Stefan Roese wrote:
Hi Dinh, Hi Vince!
a quick question for you:
On 07.11.2014 16:04, Marek Vasut wrote:
<snip>
diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadence_qspi_apb.c new file mode 100644 index 0000000..00a115f --- /dev/null +++ b/drivers/spi/cadence_qspi_apb.c @@ -0,0 +1,898 @@ +/*
- Copyright (C) 2012 Altera Corporation <www.altera.com>
- All rights reserved.
- Redistribution and use in source and binary forms, with or without
- modification, are permitted provided that the following conditions are
met: + * - Redistributions of source code must retain the above copyright
- notice, this list of conditions and the following disclaimer. + *
- Redistributions in binary form must reproduce the above copyright + *
notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + *
- Neither the name of the Altera Corporation nor the
- names of its contributors may be used to endorse or promote products
- derived from this software without specific prior written
permission. + *
- THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL ALTERA CORPORATION BE LIABLE FOR ANY + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */
This license is kinda iffy. What is this all about please ?
Yes, I was wondering about this as well. And in the Linux kernel (Rocketboards) this file is dual licensed. Here an extract:
<------- /*
- Driver for Cadence QSPI Controller
- Copyright (C) 2012 Altera Corporation
- This software is available to you under a choice of one of two
- licenses. You may choose to be licensed under the terms of the GNU
- General Public License (GPL) Version 2, available from the file
- COPYING in the main directory of this source tree, or the
- OpenIB.org BSD license below:
Redistribution and use in source and binary forms, with orwithout modification, are permitted provided that the followingconditions are met:- Redistributions of source code must retain the abovecopyright notice, this list of conditions and the followingdisclaimer.- Redistributions in binary form must reproduce the abovecopyright notice, this list of conditions and the followingdisclaimer in the documentation and/or other materialsprovided with the distribution.- THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
- EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
- MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
- BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
- ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
- CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- SOFTWARE.
*/ <------
Could we not just use a "plain" GPL (v2) license here as well. Especially since the other files in this driver are just normal GPL files.
Comments welcome.
Graham recent posted to lkml a patch series for QSPI that has a plain GPLv2.
http://marc.info/?l=linux-kernel&m=141417788514196&w=2
Dinh