Two functions in this file return early for no good reason. Adjust the code to match the standard DM style of returning 0 at the end of the function on success.
Oddly enough this save 12 bytes of code size on ARM.
Signed-off-by: Simon Glass sjg@chromium.org ---
drivers/core/uclass.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c index b33296542f6..af575bbeb72 100644 --- a/drivers/core/uclass.c +++ b/drivers/core/uclass.c @@ -714,8 +714,11 @@ int uclass_pre_probe_device(struct udevice *dev) if (!dev->parent) return 0; uc_drv = dev->parent->uclass->uc_drv; - if (uc_drv->child_pre_probe) - return uc_drv->child_pre_probe(dev); + if (uc_drv->child_pre_probe) { + ret = uc_drv->child_pre_probe(dev); + if (ret) + return ret; + }
return 0; } @@ -735,8 +738,11 @@ int uclass_post_probe_device(struct udevice *dev) }
uc_drv = dev->uclass->uc_drv; - if (uc_drv->post_probe) - return uc_drv->post_probe(dev); + if (uc_drv->post_probe) { + ret = uc_drv->post_probe(dev); + if (ret) + return ret; + }
return 0; }