Re: [U-Boot] [PATCH v4 2/6] serial: add UniPhier serial driver

Hi Simon,

2014-09-06 1:41 GMT+09:00 Simon Glass sjg@chromium.org:

...

Maybe we can move "\n -> \r\n" logic to the upper layer and allow users to enable/disable it with a CONFIG_ option.

Do you think we could use driver model instead? We have the serial infrastructure in place and I will likely merge it next week.

OK. I haven't checked it yet, but I will next week.

It moves the \r\n logic to a higher level.

It also removes the need for all the horrible #define stuff you have here to deal with multiple serial ports.

Does your board have SPL? If so, does it use serial in SPL?

Yes, all the UniPhier boards have SPL support.

The serial in SPL is not currently supported, but I am planning to add it in the next phase.