Dear Luca Ceresoli,
In message 4D877D80.6060506@comelit.it you wrote:
It appears you base this code on an old version of U-Boot. Please update your code base first.
Strange.
My patch is based on current master, on the latest commit that I see today on git://git.denx.de/u-boot.git:
Sorry. I thought we had cleaned up the config.mk file use for these boards long ago. Seems I was wrong.
WARNING: Use #include <linux/io.h> instead of <asm/io.h> #169: FILE: board/comelit/cps/cps.c:39: +#include <asm/io.h>
I guess I can safely ignore this one.
Yes.
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#1011: FILE: include/configs/omap3_cps.h:305: +extern volatile unsigned int boot_flash_env_addr;
I don't know why it is volatile, but since it's defined this way in arch/arm/cpu/armv7/omap3/mem.c I think there's a reason.
No, this should be removed. See Documentation/volatile-considered-harmful.txt
We don't accept such config.mk files any more. Please move definition into your board config file.
Meaning I should remove config.mk entirely, right?
Right.
Please name your board just "cps" (or chose a better name). There shall be no SoC-prefix in the board names.
Will be called dig297 in v2.
Thanks.
#defines like these which select a feature shall not have values assigned. Remove all these '1' here. Please fix globally.
Ok except for OMAP34XX, since arch/arm/cpu/armv7/start.S at line 114 does:
#if (CONFIG_OMAP34XX)
Is it intended? If that's a mistake, I can submit a trivial patch to fix it.
Ouch. This is wrong and should be fixed. Yes, please send a (separate) patch for that.
Best regards,
Wolfgang Denk