Re: [U-Boot] dm: mmc: fsl_esdhc: Drop mmc_init() call from fsl_esdhc_init()

Hi,

On 20 November 2017 at 23:11, Y.b. Lu yangbo.lu@nxp.com wrote:

Hi Simon,

I found your below patch just dropping mmc_create() for probe procedure of DM.

Actually the description seemed to be not the things this patch did.

dm: mmc: fsl_esdhc: Drop mmc_init() call from fsl_esdhc_init()

Do you have any suggestion to fix it?

mmc_create() will allocate mmc structure and the DM in fsl_esdhc also allocate mmc structure in fsl_esdhc_plat structure.

Do we need to rework the mmc_create(), or move rest initialization of mmc_create() in to fsl_esdhc_probe() ?

But mmc_create() is only used in legacy code, not with driver model.

Why do you want to call it here? Does your board not use CONFIG_DM_MMC?

Thanks a lot.

Regards, Simon