Cleanup the env_onenand.c checkpatch warnings, errors and coding style.
Signed-off-by: Igor Grinberg grinberg@compulab.co.il --- common/env_onenand.c | 12 +++++------- 1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/common/env_onenand.c b/common/env_onenand.c index c09fdf3..f356056 100644 --- a/common/env_onenand.c +++ b/common/env_onenand.c @@ -31,14 +31,12 @@ #include <malloc.h> #include <search.h> #include <errno.h> +#include <onenand_uboot.h>
#include <linux/mtd/compat.h> #include <linux/mtd/mtd.h> #include <linux/mtd/onenand.h>
-extern struct mtd_info onenand_mtd; -extern struct onenand_chip onenand_chip; - char *env_name_spec = "OneNAND";
#define ONENAND_MAX_ENV_SIZE 4096 @@ -48,7 +46,7 @@ DECLARE_GLOBAL_DATA_PTR;
uchar env_get_char_spec(int index) { - return (*((uchar *)(gd->env_addr + index))); + return *((uchar *)(gd->env_addr + index)); }
void env_relocate_spec(void) @@ -76,7 +74,7 @@ void env_relocate_spec(void) if (mtd->writesize) /* Ignore read fail */ mtd->read(mtd, env_addr, ONENAND_MAX_ENV_SIZE, - &retlen, (u_char *)buf); + &retlen, (u_char *)buf); else mtd->writesize = MAX_ONENAND_PAGESIZE; #endif /* !ENV_IS_EMBEDDED */ @@ -126,7 +124,7 @@ int saveenv(void) }
if (mtd->write(mtd, env_addr, ONENAND_MAX_ENV_SIZE, &retlen, - (u_char *)&env_new)) { + (u_char *)&env_new)) { printf("OneNAND: write failed at 0x%llx\n", instr.addr); return 2; } @@ -137,7 +135,7 @@ int saveenv(void) int env_init(void) { /* use default */ - gd->env_addr = (ulong) & default_environment[0]; + gd->env_addr = (ulong)&default_environment[0]; gd->env_valid = 1;
return 0;