Re: [U-Boot] [PATCH V4 01/11] imximage: mx53 needs transfer length a multiple of 512

Dear Troy Kisky,

In message 1354066303-29762-2-git-send-email-troy.kisky@boundarydevices.com you wrote:

The mx53 ROM will truncate the length at a multiple of 512. Transferring too much is not a problem, so round up.

What about other SoCs using the same code?

+#define ALIGN(a, b) (((a) + (b) - 1) & ~((b) - 1))

NAK. This macro is mis-named; it has nothing to do with alignment - you write yourself: "round up".

And you don't have to re-invent the wheel. Please use the existing macros for this purpose.

Best regards,

Wolfgang Denk