Dear matt.waddel@linaro.org,
From: Matt Waddelmatt.waddel@linaro.org
These patches add support for the ARM PrimeCell PL180 MultiMedia Interface. The Versatile Express was the test platform for these changes.
Matt Waddel (3): MMC: Max blocks value adjustable MMC: Add support for PL180 ARM mmc device ARMV7: Vexpress: Add MMC support
board/armltd/vexpress/ca9x4_ct_vxp.c | 9 + drivers/mmc/Makefile | 1 + drivers/mmc/mmc.c | 19 +- drivers/mmc/mmci.c | 452 ++++++++++++++++++++++++++++++++++ drivers/mmc/mmci.h | 181 ++++++++++++++
I would expect something more descriptive like <hardware>_mmc.[ch] here. mmci.[ch] does not lead one to think its a hardware specific driver, even less for what specific hardware it is. The same is true for the exported function name "mmci_init", the macro CONFIG_MMCI etc.
Then, in patch 2/3:
+int mmci_init(void)
but in patch 3/3:
+ rc = mmci_init(bis);
Seems you should add a prototype to include/mmc.h to detect such mistakes ;)
Best Regards, Reinhard