Hi Wolfgang,
Dear Lukasz,
In message 20140131102755.63297928@amdc2363 you wrote:
ext4write mmc 0:2 ${addr} ${filename} ${filesize}
Change this to use the standard notation of base 16 input format. See also commit b770e88
WARNING: this is a change to the user interface!!
In other words you are breaking API :-) - but this change is more than welcome and you have got enough power to do it :-).
Yes, I'm breaking the current (incorrectly implemented) ABI to fix it and make it consistend with other use (for example, "fatwrite"). As is, it can only be used from the command line, but not from any scripts that refer for example to ${filesize}.
And I'm totally with you with this change.
My only comment is to add proper description to the ext4write commend description. Now it only says:
"<interface> <dev[:part]> <addr> <absolute filename path> [sizebytes]\n"
and I think, that we could come up with [sizebytes - HEX] or something similar.
I do not see any such need. Hex input base is the established and documented default - ext4write is not a special command, so why should we mention this here when we do not mention it anywhere else?
If now all <fs>*write and <fs>*load commands accept only hex input, then I agree, that extra comment is not needed.
Best regards,
Wolfgang Denk