On Mon, May 12, 2014 at 09:36:54AM +0200, Heiko Schocher wrote:
Hello Tom, Simon, Wolfgang, Lars,
[snip]
Ok, summary for one first step (I can do):
introduce CONFIG_IMAGE_FORMAT_LEGACY based on patch [1] (rename "+#if !defined(CONFIG_DISABLE_IMAGE_FORMAT_LEGACY)" to "+#if defined(CONFIG_IMAGE_FORMAT_LEGACY)")
set CONFIG_IMAGE_FORMAT_LEGACY as default: (little bit adapted towards simons CONFIG_FIT_SIGNATURE_VERIFICATION proposal ... I dont want to introduce a new define ...)
in config_defaults: +#ifndef CONFIG_FIT_SIGNATURE +#define CONFIG_IMAGE_LEGACY +#endif
so, if boards not define CONFIG_FIT_SIGNATURE, they have default CONFIG_IMAGE_FORMAT_LEGACY enabled (as currently).
If CONFIG_FIT_SIGNATURE is enabled, legacy image format is default disabled (change current behaviour of boards, which use this feature! This is only the case for:
$ grep -lr CONFIG_FIT_SIGNATURE include/ include/configs/zynq-common.h -> Michal, add Michal therefore to Cc include/configs/sandbox.h -> Simon include/configs/ids8313.h -> me include/image.h $
), but boards can enable it if needed (as ids8313 board needs it ... yes not nice ...)
If boards which have not enabled CONFIG_FIT_SIGNATURE and want to disable legacy image format ... we can add this case if we want like:
in config_defaults: +#ifndef CONFIG_FIT_SIGNATURE +#define CONFIG_IMAGE_LEGACY +#endif
+#ifdef CONFIG_DISABLE_IMAGE_LEGACY +#undef CONFIG_IMAGE_LEGACY +#endif
Is this a way to go?
Sounds right to me, thanks.