
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message 20090812203659.GB21725@game.jcrosoft.org you wrote:
+#ifdef CONFIG_SMC_USE_32_BIT +#define USE_32BIT 1 +#else +#define USE_32BIT 0 +#endif
Above you get rid of the USE_32BIT stuff; here you re-introduce it. Why?
yes it's different here it's to declare that you want to activate the 32bit for the default driver init
Why not use the same method as above?
This is a pretty long list of boards which is affected. How many of these have actuaaly been tested with this patch, and which ones, and to what extent?
none will be impact as the share the same init and I've not modify any config just active the multi support
Come on. You make heavy changes to the driver ans claim that none of the boards would be affected? This is... very naïve at best.
and the code is tested on custom boards (4 differents) + nhk8815
I see. You should ask board maintainers for feedback, then.
Best regards,
Wolfgang Denk