On Wed, Feb 13, 2013 at 7:36 PM, Marek Vasut marex@denx.de wrote:
Dear Otavio Salvador,
On Wed, Feb 13, 2013 at 7:19 PM, Marek Vasut marex@denx.de wrote:
Dear Otavio Salvador,
This adds support to the LAN9512 chip included in the board and extend the environment to easy netboot use.
Signed-off-by: Otavio Salvador otavio@ossystems.com.br
You completely ignored previous discussion to make this ethernet thingie part of the previous patch.
I made the HUB part of the previous patch; I don't agree in moving ethernet to there.
The ethernet is integral part of the hub chip. This approach you take here breaks bisectability.
It does not; in case you do bisect you'll be able to build and run both revisions; it'll be a matter of one more 'bad' command call. I prefer to keep it split as it is much easier for someone reading the history to stop what has been done.