
Dear Mike Frysinger,
In message 1230009039-20117-1-git-send-email-vapier@gentoo.org you wrote:
Rather than have the board code initialize SATA automatically during boot, make the user manually run "sata init". This brings the SATA subsystem in line with common U-Boot policy.
Rather than having a dedicated weak function "is_sata_supported", people can override sata_initialize() to do their weird board stuff. Then they can call the actual __sata_initialize().
Signed-off-by: Mike Frysinger vapier@gentoo.org
v3
- redo how the board weak is handled to be less bloated when screwing over everyone else
v2
- auto run `sata init` if needed when doing other `sata ...` cmds
board/freescale/mpc8536ds/mpc8536ds.c | 6 +++--- common/cmd_sata.c | 12 +++++++++++- include/sata.h | 1 + lib_ppc/board.c | 20 -------------------- 4 files changed, 15 insertions(+), 24 deletions(-)
Sorry, this doesn;t apply any more:
error: patch failed: board/freescale/mpc8536ds/mpc8536ds.c:582 error: board/freescale/mpc8536ds/mpc8536ds.c: patch does not apply Using index info to reconstruct a base tree... error: patch failed: board/freescale/mpc8536ds/mpc8536ds.c:582 error: board/freescale/mpc8536ds/mpc8536ds.c: patch does not apply Did you hand edit your patch? It does not apply to blobs recorded in its index. Cannot fall back to three-way merge. Patch failed at 0001.
Please rebase and resubmit. Thanks.
Best regards,
Wolfgang Denk