On Wed, Jul 13, 2022 at 07:36:02PM +0200, Heinrich Schuchardt wrote:
On 7/11/22 19:14, Tom Rini wrote:
[snip]
+Work flow of a Custodian +------------------------
+The normal flow of work in the U-Boot development process will look +like this:
+#. A developer submits a patch via e-mail to the u-boot-users mailing list.
- U-Boot has adopted the `Linux kernel signoff policy https://groups.google.com/g/fa.linux.kernel/c/TLJIJVA-I6o?pli=1`_, so the submitter must
- include a ``Signed-off-by:`` line.
+#. Everybody who can is invited to review and test the changes. Reviews should
- reply on the mailing list with ``Acked-by`` lines.
+#. The responsible custodian
- #. inspects this patch, especially for:
This should not be a bullet point.
- #. :doc:`codingstyle`
- #. Basic logic:
* The patch fixes a real problem.* The patch does not introduce new problems, especially it does not breakother boards or architectures- #. U-Boot Philosophy
- #. Applies cleanly to the source tree
- #. passes a ``MAKEALL`` compile test without creating new warnings
+#. Notes:
- #. In some cases more than one custodian may be affected or feel responsible.
To avoid duplicated efforts, the custodian who starts processing thepatch should send a short ACK to the mailing list.- #. We should create some tool to automatically do this.
- #. This is well documented in :doc:`designprinciples`.
- #. The custodian decides himself how recent the code must be. It is
acceptable to request patches against the last officially releasedversion of U-Boot or newer. Of course a custodian can also acceptpatches against older code.This paragraph is unclear. How about:
Patches should be based on the git HEAD. If merge conflicts arise, the custodian decides to either rebase the patch himself or to request the submitter for a rebased patch.
- #. Commits should show original author in the ``author`` field and include all
sign off/ack lines.Sign-off, Acked-by, Reviewed-by lines.
Please comment on the later patch where I re-write this section a good deal. To repeat, I do not want to make significant changes to these documents in the same commit that imports them from the wiki.