Dear "David Wu",
In message op.vawhtyh7qigx4y@cyprus.local you wrote:
Signed-off-by: David Wu davidwu@arcturusnetworks.com
board/Mercury/ep2500/Makefile | 44 ++++++ board/Mercury/ep2500/config.mk | 23 +++ board/Mercury/ep2500/ep2500.c | 191 +++++++++++++++++++++++++ board/Mercury/ep2500/u-boot.lds | 140 ++++++++++++++++++ include/configs/EP2500.h | 297+++++++++++++++++++++++++++++++++++++++ 5 files changed, 695 insertions(+), 0 deletions(-) create mode 100644 board/Mercury/ep2500/Makefile create mode 100644 board/Mercury/ep2500/config.mk create mode 100644 board/Mercury/ep2500/ep2500.c create mode 100644 board/Mercury/ep2500/u-boot.lds create mode 100644 include/configs/EP2500.h
PLEASE! Please add version information to such submissions, i. e. use something like "[PATCH 2/6 v2]" in the subject, and add a descreiption of what you have changed compared to the previous version of the patches!!
Entries to MAINTAINERS and MAKEALL missing.
...
/* Write to this block to initiate precharge */if (j == 0)*(vu_short *) (base) = 0x0000;else*(vu_short *) (base) = 0xbabe;
I guess you have proper I/O accessor functions on this architecture? [Please fix globally.]
....
- /*
* When buff returns all 0xFF the EEPROM has not* been programed with a valid MAC. In this case* we set enet to all 0x00 as 0xFF is not valid* for this usage model.*/- if (buff[0] == 0xff && buff[1] == 0xff && buff[2] == 0xff &&
buff[3] == 0xff && buff[4] == 0xff && buff[5] == 0xff) {for (i = 0; i < 6; i++)enet[i] = 0;- } else {
for (i = 0; i < 6; i++)enet[i] = buff[i];- }
Please see review comments to previous patch.
+void i2c_init_board(void) +{
- struct fsl_i2c *dev;
- dev = (struct fsl_i2c *)(CONFIG_SYS_IMMR + CONFIG_SYS_I2C_OFFSET);
- if (readb(&dev->sr) & I2C_SR_MBB) {
writeb(0, &dev->cr);writeb(0xa0, &dev->cr);readb(&dev->dr);writeb(0x0, &dev->sr);writeb(0, &dev->cr);writeb(I2C_CR_MEN, &dev->cr);- }
Ditto.
...
+#define CONFIG_BOOTDELAY 5 +#ifdef CONFIG_MCFFEC +# define CONFIG_ETHADDR 00:00:00:00:00:00 +# define CONFIG_IPADDR 192.168.1.2 +# define CONFIG_NETMASK 255.255.255.0 +# define CONFIG_SERVERIP 192.168.1.1 +# define CONFIG_GATEWAYIP 192.168.1.1 +# define CONFIG_OVERWRITE_ETHADDR_ONCE +/*#define CONFIG_ENV_OVERWRITE */ +#endif /* CONFIG_MCFFEC */
Ditto, and so on.