Hello Stefan,
Stefan Roese wrote:
On Tuesday 27 May 2008, Wolfgang Denk wrote:
Signed-off-by: Sergei Poselenov sposelenov@emcraft.com
board/socrates/socrates.c | 13 +++++++++++-- include/configs/socrates.h | 3 ++- 2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/board/socrates/socrates.c b/board/socrates/socrates.c index cb58994..15c6478 100644 --- a/board/socrates/socrates.c +++ b/board/socrates/socrates.c @@ -45,6 +45,9 @@ ulong flash_get_size (ulong base, int banknum);
int checkboard (void) {
volatile ccsr_gur_t *gur = (void *)(CFG_MPC85xx_GUTS_ADDR);
char *src;
int f; char *s = getenv("serial#");
puts("Board: Socrates");
@@ -55,8 +58,14 @@ int checkboard (void) putc('\n');
#ifdef CONFIG_PCI
- printf ("PCI1: 32 bit, %d MHz (compiled)\n",
CONFIG_SYS_CLK_FREQ / 1000000);
- if (gur->porpllsr & (1<<15)) {
Please don't use pointer access for such SoC registers. in_be32() is recommended here.
What is the reason for doing this? Compiler issues? I see the direct pointer addressing is used all over the 85xx code.
Regards, Sergei
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================