Dear "kevin.morfitt@fearnside-systems.co.uk",
In message 4B6EC9D5.6060201@fearnside-systems.co.uk you wrote:
Patches 1 and 2 contain only white-space changes and patch 3 contains only code style changes (moving external function prototypes to header files, removing unused code, making line lengths less than 81 characters, brackets around if/then/else/when/do blocks, generally anything that checkpatch.pl warns about). I can merge these together as long as nobody objects to having white-space and code style changes in a single patch?
I find this split (white-space changes only first, code style changes then) pretty logical. I would suggest to combine patches 1 + 2 because they belong together, and the split was done only to keep the size of the patch within the soft-limit of this mailing list.
I would not fight against combining all 3 into a single commit, but I don't think it would make the code any better - just harder to follow the changes.
I suggest not to do this, then - just combine 1+2 regardless of the mailing list limit, and rebase.
Thanks.
Wolfgang Denk