On Fri, 2006-11-03 at 00:16, Sam Song wrote:
Hi,
The following feedback can be considered for next
fixes. Not to take effect on this patchset apply.
Sam,
Based on your comments, I have generate the following patch base on my
previous patch(v3 version).
At the same time, the update is reflected on my git repo
http://opensource.freescale.com/git?p=u-boot-7448hpc2.git;a=summary
Thanks for your comment.
Roy
=====================================================================
Change the TEXT_BASE from 0xFFF00000 to 0xFF000000.
Both work. 0xFF000000 seems more reasonable.
Signed-off-by: Roy Zang tie-fei.zang@freescale.com
---
board/mpc7448hpc2/config.mk | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/board/mpc7448hpc2/config.mk b/board/mpc7448hpc2/config.mk
index 9147a5c..2e58858 100644
--- a/board/mpc7448hpc2/config.mk
+++ b/board/mpc7448hpc2/config.mk
@@ -21,7 +21,7 @@ # MA 02111-1307 USA
#
# Flash address
-TEXT_BASE = 0xFFF00000
+TEXT_BASE = 0xFF000000
# RAM address
#TEXT_BASE = 0x00400000
--
1.4.0
=======================================================================
Remove some unused CFG define.
undef CFG_DRAM_TEST
Signed-off-by: Roy Zang
tie-fei.zang@freescale.com
---
include/configs/mpc7448hpc2.h | 15 +++------------
1 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/include/configs/mpc7448hpc2.h b/include/configs/mpc7448hpc2.h
index 9243d58..24cc86b 100644
--- a/include/configs/mpc7448hpc2.h
+++ b/include/configs/mpc7448hpc2.h
@@ -149,10 +149,6 @@ #define CONFIG_GATEWAYIP 172.27.255.2
#define CONFIG_BOOTFILE zImage.initrd.elf
#define CONFIG_LOADADDR 0x400000
-#define CONFIG_TESTDRAMDATA y
-#define CONFIG_TESTDRAMADDRESS n
-#define CONFIG_TESETDRAMWALK n
-
/*-------------------------------------------------------------------------- */
#define CONFIG_LOADS_ECHO 0 /* echo off for serial download */
@@ -163,10 +159,6 @@ #undef CONFIG_WATCHDOG /* watchdog disa
#define CONFIG_BOOTP_MASK (CONFIG_BOOTP_DEFAULT | \
CONFIG_BOOTP_BOOTFILESIZE)
-/* Flash banks JFFS2 should use */
-#define CFG_JFFS2_FIRST_BANK 1
-#define CFG_JFFS2_NUM_BANKS 1
-
#define CONFIG_COMMANDS (CONFIG_CMD_DFL \
| CFG_CMD_ASKENV \
| CFG_CMD_CACHE \
@@ -174,7 +166,6 @@ #define CONFIG_COMMANDS (CONFIG_CMD_DFL
| CFG_CMD_I2C \
| CFG_CMD_SDRAM \
| CFG_CMD_EEPROM \
- | CFG_CMD_NET \
| CFG_CMD_FLASH \
| CFG_CMD_ENV \
| CFG_CMD_BSP \
@@ -220,7 +211,7 @@ #define CFG_DRAM_TEST
* CFG_DRAM_TEST_DATA - Enables test for shorted or open data lines
* Environment variable 'test_dram_data' must be
* set to 'y'.
- * CFG_DRAM_TEST_DATA - Enables test to verify that each word is uniquely
+ * CFG_DRAM_TEST_ADDRESS - Enables test to verify that each word is uniquely
* addressable. Environment variable
* 'test_dram_address' must be set to 'y'.
* CFG_DRAM_TEST_WALK - Enables test a 64-bit walking ones pattern test.
@@ -228,10 +219,10 @@ #define CFG_DRAM_TEST
* Environment variable 'test_dram_walk' must be
* set to 'y'.
*/
-#define CFG_DRAM_TEST
-#if defined(CFG_DRAM_TEST)
+#undef CFG_DRAM_TEST
#define CFG_MEMTEST_START 0x00400000 /* memtest works on */
#define CFG_MEMTEST_END 0x07c00000 /* 4 ... 124 MB in DRAM */
+#if defined(CFG_DRAM_TEST)
#define CFG_DRAM_TEST_DATA
#define CFG_DRAM_TEST_ADDRESS
#define CFG_DRAM_TEST_WALK
--
1.4.0
