Hi Julius,
On 5 October 2015 at 19:09, Julius Werner jwerner@chromium.org wrote:
You can build U-Boot with NO_SDL=1
Ah, thanks... that was the important magic flag I needed!
Actually you should enable the option in configs/sandbox_defconfig, not lib/Kconfig. See the condition used by compression.c:
obj-$(CONFIG_SANDBOX) += compression.o
Okay, makes sense. I looked at the wrong line in the Makefile.
Also, for me the test fails:
./b/sandbox/u-boot -c "ut_compression" ... testing lz4 ... orig_size:350 compressed_size:276 uncompressed_size:350 compress does not overrun Failed: ret != 0 lz4: FAILED ut_compression FAILED
Huh... that's odd. When I run this now, I get:
testing lz4 ... orig_size:350 compressed_size:276 uncompressed_size:350 compress does not overrun uncompress does not overrun lz4: ok
And if I change a byte in the compressed test data, it fails on memcmp() as expected. Are you sure you have no local changes or anything (I based the patch off 1f8836396)? I don't see how this could give different results...
git reset --hard HEAD~ HEAD is now at 1f88363 Prepare v2015.10-rc4 (try-julius=1f8836: asc.1 b/ et sandbox/) ~/u> !pw pwclient git-am 525863 Applying patch #525863 using 'git am' Description: [U-Boot,PATCHv2] Add support for LZ4 decompression algorithm Applying: Add support for LZ4 decompression algorithm .git/rebase-apply/patch:91: trailing whitespace.
warning: 1 line adds whitespace errors. (try-julius=b3cf2a: asc.1 b/ et sandbox/) ~/u> 1cro 1cro: command not found 127 (try-julius=b3cf2a: asc.1 b/ et sandbox/) ~/u> !cro crosfw -b sandbox -w
../lib/lz4_wrapper.c: In function ‘ulz4fn’: ../lib/lz4_wrapper.c:72:6: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized] int ret; ^
./b/sandbox/u-boot -c "ut_compression"
U-Boot 2015.10-rc4-00001-gb3cf2a9 (Oct 06 2015 - 14:42:07 +0100)
DRAM: 128 MiB Using default environment
In: serial Out: lcd Err: lcd Net: No ethernet found. testing gzip ... orig_size:350 compressed_size:206 uncompressed_size:350 Deflate need more space to compress left 350 bytes compress does not overrun Error: inflate() returned -5 uncompress does not overrun gzip: ok testing bzip2 ... orig_size:350 compressed_size:240 uncompressed_size:350 compress does not overrun uncompress does not overrun bzip2: ok testing lzma ... orig_size:350 compressed_size:229 uncompressed_size:350 compress does not overrun uncompress does not overrun lzma: ok testing lzo ... orig_size:350 compressed_size:334 uncompressed_size:350 compress does not overrun uncompress does not overrun lzo: ok testing lz4 ... orig_size:350 compressed_size:276 uncompressed_size:350 compress does not overrun Failed: ret != 0 lz4: FAILED ut_compression FAILED
I pushed it to u-boot-x86 branch 'julius-working' for you to check.
Regards, Simon