On 29.05.2018 23:13, Michael Walle wrote:
This patch shows how to enable driver model support for the LS-CHLv2 and LS-XHL boards.
There are a couple of open questions:
- do I need the u-boot,dm-pre-reloc tags in the device tree?
This property is only needed for SPL build targets - which Kirkwood currently is not (AFAIK).
- should mach/config.h define CONFIG_DM_SEQ_ALIAS?
No. It defaults to "y" already. And we should not move options into the config headers anymore but put them into the Kconfig system instead.
- how can we split this patch or are there any other pending patches which does the same and I didn't catch these.
I see no need to split this patch. There are the patches from Chris moving Kirkwood to device-tree - which you most likely already know. Most of them are applied.
This patch is based on the http://git.denx.de/u-boot-marvell.git (master branch) and needs the following patches, which are still pending: https://patchwork.ozlabs.org/patch/909618/ https://patchwork.ozlabs.org/patch/909617/ https://patchwork.ozlabs.org/patch/909973/
Signed-off-by: Michael Walle michael@walle.cc Tested-by: Michael Walle michael@walle.cc
I think there is no need to add the "Tested-by" tag for the patch author. It should be obvious that you have tested this patch.
Thanks, Stefan