On Thu, Feb 16, 2023 at 03:21:43PM +0100, Marek Vasut wrote:
On 2/16/23 15:13, Tom Rini wrote:
On Thu, Feb 16, 2023 at 03:04:35PM +0100, Marek Vasut wrote:
On 2/16/23 04:36, Tom Rini wrote:
On this platform spl_board_init is a call to arch_misc_init which is a no-op, so drop the CONFIG options.
Cc: Marek Vasut marex@denx.de Cc: Olaf Mandel o.mandel@menlosystems.com
btw. put those under --- next time, that way they don't end up in commit message.
Er, did the kernel change expected behavior here?
Er ... wasn't that the case for like a year now ?
Is that a yes then?
Signed-off-by: Tom Rini trini@konsulko.com
If CAAM is enabled, ARCH_MISC_INIT brings up the CAAM , and this is needed in SPL for U-Boot authentication using HABv4 . I believe that is why Verdin spl.c calls it.
Then I'll put doing a follow-up on SPL_BOARD_INIT (which is another option that shouldn't be directly asked, but select'd when used) for that case. It fails to build in this series because CAAM isn't enabled so there's no arch_misc_init.
Just call the arch_board_init unconditionally, the CAAM inside of it is already conditional, so the compiler should inline the result if CAAM is disabled.
It doesn't, and only maybe does with LTO. But we also shouldn't be enabling unused hooks. It sounds like imx8m should follow the other platforms that have an spl_board_init under arch/ ?