Dear Rob Herring,
In message 1323199478-21001-1-git-send-email-robherring2@gmail.com you wrote:
From: Rob Herring rob.herring@calxeda.com
If the net driver has setup a valid ethernet address and an ethernet address is not set in the environment already, then set the environment variables from the net driver setting
This enables pxe booting on boards which don't set ethaddr env variable.
Signed-off-by: Rob Herring rob.herring@calxeda.com
v2:
- Re-wrote to always setup ethaddr env variables
doc/README.enetaddr | 4 +++- net/eth.c | 19 ++++++++++++++++--- 2 files changed, 19 insertions(+), 4 deletions(-)
I asked before:
... If the "ethaddr" environment variable is not set, then this alternative value can be used as default. In this case a warning should be printed. If both settings exist and differ, the "ethaddr" environment variable shall be used, and a warning be printed, too.
I do not see any wanings in your patch?
Best regards,
Wolfgang Denk