On Thursday, November 06, 2014 at 02:02:59 PM, Wolfgang Denk wrote:
Fix error detected by cppcheck:
[drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: ''. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'ISP116X_HCD_OC_ENABLE'. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'ISP116X_HCD_REMOTE_WAKEUP_ENABLE'. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'ISP116X_HCD_SEL15kRES'. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'ISP116X_HCD_USE_EXTRA_DELAY'. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'ISP116X_HCD_USE_UDELAY'. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'TRACE'. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'TRACE;VERBOSE'. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'VERBOSE'.
Signed-off-by: Wolfgang Denk wd@denx.de Cc: Stephen Warren swarren@wwwdotorg.org Cc: Marek Vasut marex@denx.de
A brief grep: marex@bfu:u-boot$ git grep USB_ISP116X_HCD drivers/usb/host/Makefile:obj-$(CONFIG_USB_ISP116X_HCD) += isp116x-hcd.o include/usb.h: defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || \ marex@bfu:u-boot$
gives me a better idea on how to resolve this bug ... scrap this code altogether. Looks like the code was unused forever. Can you prepare a patch for that please ?
Best regards, Marek Vasut