On Thursday 28 April 2016 10:01 AM, Joe Hershberger wrote:
On Wed, Apr 27, 2016 at 1:33 AM, Mugunthan V N mugunthanvnm@ti.com wrote:
On Wednesday 27 April 2016 03:06 AM, Joe Hershberger wrote:
On Mon, Apr 25, 2016 at 4:53 PM, Joe Hershberger joe.hershberger@gmail.com wrote:
On Tue, Apr 12, 2016 at 3:46 AM, Mugunthan V N mugunthanvnm@ti.com wrote:
Different TI platforms has to read with different combination to get the mac address from efuse. So add support to read mac address based on machine/device compatibles.
The code is taken from Linux drivers/net/ethernet/ti/cpsw-common.c done by Tony Lindgren.
Signed-off-by: Mugunthan V N mugunthanvnm@ti.com
Acked-by: Joe Hershberger joe.hershberger@ni.com
This is not checkpatch.pl clean. Please resubmit.
609306.mbox:92: WARNING: line over 80 characters 609306.mbox:132: WARNING: line over 80 characters
WARNING: line over 80 characters #103: FILE: drivers/net/cpsw-common.c:39:
error("Not able to get syscon address to get mac efuse address\n");WARNING: line over 80 characters #143: FILE: drivers/net/cpsw-common.c:79:
error("Not able to get syscon address to get mac efuse address\n");total: 0 errors, 2 warnings, 0 checks, 184 lines checked
These warnings are from error logs which can be ignored as it makes life easier to grep the source when issue is found. The same is followed in kernel as well.
OK. Please address the other patch as well. Are all failures justifiable for the same reason?
I just reposted the v3 of this patches with rebase to u-boot/master. I get only the above two checkpatch warning for the whole series, is there some other warning else you get in your testing?
Regards Mugunthan V N