Re: [U-Boot] [RESEND PATCH 3/5] usb: host: dwc2: force reset assert

On 10/14/19 10:00 AM, Patrick Delaunay wrote:

Assert reset before deassert in dwc2_reset; It should be more safe for DWC2.

Can you be more descriptive about this issue ? I have no idea what this patch does or fixes from the description.

Signed-off-by: Patrick Delaunay patrick.delaunay@st.com

drivers/usb/host/dwc2.c | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/host/dwc2.c b/drivers/usb/host/dwc2.c index 51023b0c2c..3086411fc4 100644 --- a/drivers/usb/host/dwc2.c +++ b/drivers/usb/host/dwc2.c @@ -1149,6 +1149,8 @@ static int dwc2_reset(struct udevice *dev) return ret; }

• reset_assert_bulk(&priv->resets);
• udelay(2);

Why is there a 2 uS delay ?

ret = reset_deassert_bulk(&priv->resets); if (ret) { reset_release_bulk(&priv->resets);

[...]