Re: [U-Boot] fix: fw_env: Prevent writing error message on special files, which don't support fsync

On Sun, Aug 27, 2017 at 01:46:22PM +0200, Lukasz Majewski wrote:

According to fsync specification [1] some special files (e.g., a pipe, FIFO, or socket) don't support synchronization and return either EROFS or EINVAL.

On the linux side the sys_fsync -> do_fsync() checks if the requested file has f_op->fsync defined. If not it returns EINVAL [2].

This commit prevents writing error messages for files (devices), which do not support fsync().

[1] - http://man7.org/linux/man-pages/man2/fsync.2.html [2] - http://elixir.free-electrons.com/linux/v4.13-rc6/source/fs/sync.c#L183

Signed-off-by: Lukasz Majewski lukma@denx.de Acked-by: Michael Heimpold mhei@heimpold.de

Applied to u-boot/master, thanks!