Re: [U-Boot] [PATCH V3 2/5] mv_i2c: use structure to replace the direclty define

Dear Lei Wen,

In message AANLkTikMYpVVJDRnGRVZ3XZsYTn_yprpfMUUp_3DdHbJ@mail.gmail.com you wrote:

...

...

...

•                 writel(readl(ICR) & ~ICR_ACKNA> K, ICR);
  

•         writel(readl(ICR) & ~ICR_ALDIE, ICR);
  

•         writel(readl(ICR) | ICR_TB, ICR);
  

•                 PXAI2C_AND(&base->icr, ~ICR_AC> KNAK);
  

•         PXAI2C_AND(&base->icr, ~ICR_ALDIE);
  

•         PXAI2C_OR(&base->icr, ICR_TB);
  

What are benefits of those macros? To me this looks ugly and looses readability.

This intend for short the original too long code, but I don't reject to ret> urn to the readl, write one.

Please either use plain writel() / readl() accessors, or, alternatively, implement standard accessors that could be used by everybody else for the same purpose, too.

See for example the misc clrbits*(), setbits*() or clrsetbits*() macros as dfined for example in "arch/powerpc/include/asm/io.h"

Best regards,

Wolfgang Denk