On 03. 03. 20 15:52, Andy Shevchenko wrote:
On Tue, Mar 3, 2020 at 2:03 PM Michal Simek michal.simek@xilinx.com wrote:
On 03. 03. 20 10:37, Andy Shevchenko wrote:
On Mon, Mar 2, 2020 at 10:36 AM Michal Simek michal.simek@xilinx.com wrote:
Base autodetection is failing for this case: if test 257 -gt 3ae; then echo first; else echo second; fi
It is because base for 3ae is recognized by _parse_integer_fixup_radix() as 10.
The patch is checking all chars to make sure that they are not 'a' or up. If they are base needs to be in hex.
Hold on!
for (i = 0; ; i++) {char var = s[i];if (var == '\0')break;if ((var >= 'a' && var <= 'f') ||(var >= 'A' && var <= 'F')) {*base = 16;break;}}Actually your code and commit message are unaligned. In the code you stop on the *first* hex character without checking the rest.
That's correct because base is detected as 10 at this stage.
The question is if make sense to check all chars because if there is one char between a<= <=f then you are sure that it is not base 10.
And if you want to check all of them then you need to also detect chars like ';' which can be there as you see above.
Thanks, Michal