Re: [U-Boot] [PATCH 2/3] MAKEALL: make sure to invoke GNU Make

Hello Masahiro,

On 17-07-14 11:18, Masahiro Yamada wrote:

Since the command name 'make' is not GNU Make on some platforms such as FreeBSD, MAKEALL should call the make via scripts/gnu_make.

Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com

MAKEALL | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/MAKEALL b/MAKEALL index 37ef71e..02c2f9f 100755 --- a/MAKEALL +++ b/MAKEALL @@ -630,14 +630,16 @@ build_target() { output_dir="${OUTPUT_PREFIX}" fi

• GNU_MAKE=scripts/gnu_make
• target_arch=$(get_target_arch ${target}) eval cross_toolchain=$CROSS_COMPILE_`echo $target_arch | tr '[:lower:]' '[:upper:]'` if [ "${cross_toolchain}" ] ; then

•    MAKE="make CROSS_COMPILE=${cross_toolchain}"
  

•    MAKE="$GNU_MAKE CROSS_COMPILE=${cross_toolchain}"
  

  elif [ "${CROSS_COMPILE}" ] ; then

•    MAKE="make CROSS_COMPILE=${CROSS_COMPILE}"
  

•    MAKE="$GNU_MAKE CROSS_COMPILE=${CROSS_COMPILE}"
  

  else

•    MAKE=make
  

•    MAKE=$GNU_MAKE
  

  fi

  if [ "${output_dir}" != "." ] ; then

while by itself this might be correct, opt is not a POSIX command and MAKEALL will not work at all on a BSD host. Perhaps it is time I have a look at what buildman is....

Regards, Jeroen