On Fri, Jun 9, 2017 at 11:51 PM, Wolfgang Denk wd@denx.de wrote:
I think you are talking about two parts here, and I strongly feel these should be kept separate.
The first part is support for renaming GPT partitions. The idea is clean, but should it not rather be kept general and let the user provide the new name as argument, i. e. implement a generic "gpt rename" command instead of a hard-wired "gpt flip"?
The second part is the flipping of the partition names. This is in my opinion policy, and should also not be hardwaired into this command, but left to the user. Maybe I do nmot want to fall back to the ‘backup’ partition after a single boot attempt, but instead try other things first, like booting another kernel or another device tree blob?
I feel this should be not so much hardwired, but leave more freedom for the user's creativity.
Lukasz has already made similar suggestions. In the following message is a new version which attempts to implement them.
Thanks to Lothar and Lukasz for all their help.
Best wishes, Alison Chaiken Peloton Technology