Hi Haavard,
On Tuesday 11 December 2007, Haavard Skinnemoen wrote:
This is a series of cleanups to the CFI driver I did while debugging why it refused to work on my AVR32 boards, rebased on top of the latest CFI custodian tree with "[PATCH] CFI: synchronize command offsets with Linux CFI driver" applied as well.
I'm not completely done yet, as I need more fixes to make the CFI driver work on boards like the ATNGW100. But these initial patches are seriously painful to rebase (especially #3 in this series,) so I'd like some feedback from others if I'm moving in an acceptable direction with this.
Great work so far. Thanks.
I've compile-tested the whole thing using MAKEALL on ppc (no point in testing on avr32 since no boards use this driver yet.) mcc200 failed, but it complains about lots of undefined symbols that has nothing to do with the CFI driver, so I'm pretty sure it isn't my fault.
No, I have seen this here today too. That's not related with your patch series.
Please let me know which parts of this are acceptable, and if there's something that can be done in a better way. And if you merge parts 1-3 (or even more of them), I'd be _very_ happy :-)
You have my ack at least on 1-3. And with a little rework I would gladly accept all of your patches. Looks like a great improvement to me.
There are a couple of remaining cleanups I'd like to make that go on top of this stuff, mostly related to refactoring the command set handling and adding manufacturer-specific fixups.
Good. Let's focus on your current patchset for now.
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================