Re: [U-Boot-Users] [PATCH] tftp: don't implicity trust the format of recevied packets

In message 20070830002624.4040.18733.stgit@trillian.cg.shawcable.net you wrote:

From: Grant Likely grant.likely@secretlab.ca

The TFTP OACK code trusts that the incoming packet is formated as ASCII text and can be processed by string functions. It also as a loop limit overflow bug where if the packet length is less than 8, it ends up looping over *all* of memory to find the 'blksize' string.

This patch solves the problem by forcing the packet to be null terminated and using strstr() to search for the sub string.

Signed-off-by: Grant Likely grant.likely@secretlab.ca

Thanks a lot. Applied.

Best regards,

Wolfgang Denk