Hi Rajeswari,
On Sun, May 12, 2013 at 8:40 PM, Rajeshwari Birje rajeshwari.birje@gmail.com wrote:
Hi Simon,
Thank you for reviewing the patch set. You need to apply the following patches for it to compile and work fine.
EXYNOS: Add API for power reset and exit wakeup EXYNOS: LDS file move to common EXYNOS4210: Configure GPIO for uart EXYNOS: Move files from board/samsung to arch/arm.
From the error it looks like "EXYNOS: Add API for power reset and exit wakeup" patch is missing.
Yes that fixes it, thank you. I sent an email to the maintainer with the list.
On Sun, May 12, 2013 at 12:09 AM, Simon Glass sjg@chromium.org wrote:
Hi Rajeshwari,
On Wed, Apr 24, 2013 at 11:57 PM, Rajeshwari Shinde rajeshwari.s@samsung.com wrote:
This patch performs the following:
- Convert the assembly code for memory and clock initialization to C code.
- Move the memory and clock init codes from board/samsung to arch/arm
- Creat a common lowlevel_init file across Exynos4 and Exynos5. Converted the common lowlevel_init from assembly to C-code
- Made spl_boot.c and tzpc_init.c common for both exynos4 and exynos5.
- Enable CONFIG_SKIP_LOWLEVEL_INIT as stack pointer initialisation is already
done in _main. 6) exynos-uboot-spl.lds made common across SMDKV310, Origen and SMDK5250.
TEST: Tested SD-MMC boot on SMDK5250 and Origen. Tested USB and SPI boot on SMDK5250 Compile tested for SMDKV310.
Signed-off-by: Hatim Ali hatim.rv@samsung.com Signed-off-by: Rajeshwari Shinde rajeshwari.s@samsung.com
Congratulations on getting this patch together.
It looks correct, but I had some problems getting it to build. Probably I am missing some other patch.
Configuring for smdk5250 board... lowlevel_init.c: In function ‘do_lowlevel_init’: lowlevel_init.c:50:2: warning: implicit declaration of function ‘get_reset_status’ [-Wimplicit-function-declaration] spl_boot.c: In function ‘board_init_f’: spl_boot.c:141:3: warning: implicit declaration of function ‘power_exit_wakeup’ [-Wimplicit-function-declaration] arch/arm/cpu/armv7/exynos/libexynos.o: In function `board_init_f': /mnt/host/source/src/third_party/u-boot/files/arch/arm/cpu/armv7/exynos/spl_boot.c:141: undefined reference to `power_exit_wakeup' arch/arm/cpu/armv7/exynos/libexynos.o: In function `do_lowlevel_init': /mnt/host/source/src/third_party/u-boot/files/arch/arm/cpu/armv7/exynos/lowlevel_init.c:50: undefined reference to `get_reset_status' make[1]: *** [/mnt/host/source/src/third_party/u-boot/files/spl/u-boot-spl] Error 1
I will send a separate email about the patch situation. Here are the patches I applied in reverse order - please let me know if I missed any.
d3858f7 (HEAD, snow2) EXYNOS: Move files from board/samsung to arch/arm. e666035 hack: Remove TPM definitions from exysno5-dt.h so that next patch applies cleanly c9ec2d1 EXYNOS4210: Configure GPIO for uart cf6e500 EXYNOS: LDS file move to common a40665b EXYNOS: Add API for power reset and shutdown
[snip]
Regards, Simon