Re: [U-Boot] [PATCH] sunxi: usb_phy: invert the USB phy_ctl condition

On Wed, Aug 23, 2017 at 5:01 PM, Maxime Ripard maxime.ripard@free-electrons.com wrote:

All the new SoCs from Allwinner since the A33 have had the phy_ctl offset at 0x410 instead of 0x404 that was used on the previous SoCs.

Instead of adding more and more special cases as the number of SoCs grow, let's invert the test to have 0x410 by default, and the (hopefully) fixed number of old SoCs being the exception.

Suggested-by: Siarhei Siamashka siarhei.siamashka@gmail.com Suggested-by: Chen-Yu Tsai wens@csie.org Signed-off-by: Maxime Ripard maxime.ripard@free-electrons.com

Reviewed-by: Jagan Teki jagan@openedev.com

thanks!