The function uclass_add() checks uc_drv->ops as follows:
if (uc_drv->ops) { dm_warn("No ops for uclass id %d\n", id); return -EINVAL; }
It seems odd because it warns "No ops" when uc_drv->ops has non-NULL pointer. (Looks opposite.)
Anyway, most of UCLASS_DRIVER entries have no .ops member. This check makes no sense.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com ---
drivers/core/uclass.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c index 61ca17e..901b06e 100644 --- a/drivers/core/uclass.c +++ b/drivers/core/uclass.c @@ -60,10 +60,6 @@ static int uclass_add(enum uclass_id id, struct uclass **ucp) id); return -ENOENT; } - if (uc_drv->ops) { - dm_warn("No ops for uclass id %d\n", id); - return -EINVAL; - } uc = calloc(1, sizeof(*uc)); if (!uc) return -ENOMEM;