Re: [PATCH] cmd: fs: Use part_get_info_by_dev_and_name_or_num to parse partitions

On Tue, Mar 09, 2021 at 03:56:24PM -0500, Sean Anderson wrote:

This allows using dev#partlabel syntax.

Signed-off-by: Sean Anderson sean.anderson@seco.com

fs/fs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/fs.c b/fs/fs.c index 900928c394..b7936fd4cf 100644 --- a/fs/fs.c +++ b/fs/fs.c @@ -385,8 +385,8 @@ int fs_set_blk_dev(const char *ifname, const char *dev_part_str, int fstype) } #endif

• part = blk_get_device_part_str(ifname, dev_part_str, &fs_dev_desc,

• 			&fs_partition, 1);
  

• part = part_get_info_by_dev_and_name_or_num(ifname, dev_part_str, &fs_dev_desc,

• 				    &fs_partition, 1);
  

  if (part < 0) return -1;

This breaks a small number of platforms that have FS_LOADER support without PARTITION support: xilinx_versal_mini xilinx_zynqmp_mini xilinx_zynqmp_mini_nand xilinx_zynqmp_mini_nand_single mt7620_mt7530_rfb mt7628_rfb and I suspect in all cases it's an intentional and valid config.