Hi,
net/tftp.c currently raises 82 errors and 99 warnings. This patchset fixes most of them, leaving 3 errors and 14 warnings.
Since the changes are quite massive I split them in separate patches, one per each category of errors/warning.
These issues are still present: - ERROR: else should follow close brace '}' these are due to the presence of an #ifdef right after or before the else (to compile an entire branch conditionally), and cannot be removed easily without compromising readability; - WARNING: consider using kstrto* in preference to simple_* which are Linux-specific; - WARNING: externs should be avoided in .c files these are due to loop-dependencies with other files; - WARNING: Use of volatile is usually wrong [...] I've had a quick look at these, but I don't know in detail how the networking code and Ethernet drivers (and maybe DMA?) interact, so I cannot remove them being sure that things will continue working; - WARNING: plain inline is preferred over __inline__ as I see many "__inline__"s in the current source and don't know what the U-Boot policy is.
Luca Ceresoli (8): net/tftp.c: cosmetic: fix lines over 80 characters net/tftp.c: cosmetic: fix whitespace issues net/tftp.c: cosmetic: fix pointer syntax issues net/tftp.c: cosmetic: do not use assignment in if condition net/tftp.c: cosmetic: fix brace issues net/tftp.c: cosmetic: trailing statements should be on next line net/tftp.c: cosmetic: fix indentation net/tftp.c: cosmetic: do not initialise statics to 0 or NULL
net/tftp.c | 309 ++++++++++++++++++++++++++++++++---------------------------- 1 files changed, 167 insertions(+), 142 deletions(-)
Luca