Hello Naveen,
On 26.04.2013 05:08, Naveen Krishna Ch wrote:
On 14 April 2013 22:48, Heiko Schocher hs@denx.de wrote:
Hello Naveen Krishna,
On 13.04.2013 06:42, Naveen Krishna Ch wrote:
On 6 April 2013 07:07, Naveen Krishna Chatradhi naveenkrishna.ch@gmail.com wrote:
Add support for hsi2c controller available on exynos5420.
Note: driver currently supports only fast speed mode 100kbps
Change-Id: I02555b1dc8f4ac21c50aa5158179768563c92f43 Signed-off-by: Naveen Krishna Chatradhich.naveen@samsung.com Signed-off-by: R. Chandrasekarrc.sekar@samsung.com Reviewed-by: Vadim Bendeburyvbendeb@google.com Reviewed-by: Simon Glasssjg@google.com
Changes since v3:
- Implemented get_timer instead of while and udelay for master busy
function 2. Use reg base address from device tree 3. Split the timing function to check for the errors 4. Implemented reset function for to recover from failure cases 5. Implemented a comat string for hsi2c to distingush the channels 6. Minor cosmotic changes
Note: FIFOs will be implemented in subsequent patches
drivers/i2c/s3c24x0_i2c.c | 494 +++++++++++++++++++++++++++++++++++++++++---- drivers/i2c/s3c24x0_i2c.h | 36 ++++ 2 files changed, 486 insertions(+), 44 deletions(-)
[...]
-- 1.7.9.5
Hello all i got it review by Simon and Vadim. Any updates on this driver please
As this patch in patchwork is in the responsibilty of Minkyu Kang (why?, added to cc):
Reviewed-by: Heiko Schocherhs@denx.de Acked-by: Heiko Schocher hs@denx.de
Hello Minkyu Kang,
This patch was Acked and reviewed a while ago. Can you please update on this.
Tom Rini wrote:
Naveen Krishna Ch (1): i2c: s3c24xx: add hsi2c controller support
drivers/i2c/s3c24x0_i2c.c | 494 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------ drivers/i2c/s3c24x0_i2c.h | 36 ++++++++++ post/drivers/i2c.c | 2 + 3 Dateien ge?ndert, 488 Zeilen hinzugef?gt(+), 44 Zeilen entfernt(-)
NAK. MAKEALL -a arm: --------------------- SUMMARY ---------------------------- Boards compiled: 306 Boards with errors: 3 ( snow VCMA9 smdk5250 )
And the problem is: s3c24x0_i2c.c: In function 'board_i2c_init': s3c24x0_i2c.c:945:3: error: 'COMPAT_SAMSUNG_EXYNOS5_I2C' undeclared (first use in this function)
Please fix, thanks!
bye, Heiko