On Wed, Nov 13, 2013 at 09:08:29AM -0500, Vaibhav Bedia wrote:
On Wed, Nov 13, 2013 at 3:48 AM, Lokesh Vutla lokeshvutla@ti.com wrote: [...]
I checked with hardware folks. There is no register or some way to tell if VTT is present. It is not added in EEPROM also and I have no answer why it is not added in EEPROM..:( It is specific to boards using DDR3. So its good to have it in board files as I did it here instead of adding this check in emif file.
That EEPROM is clearly not getting used the way i think it should be :\ I would have made a lot of noise to get details like this added there.
You should at least check for the GP EVM (if possible) and then enable VTT. Doing this unconditionally is bound to cause problems later on. I would also put in a big comment over there so that folks who design their own board with DDR3 don't miss this fact.
I agree, the code should be doing a check for what board we're on and enabling VTT, and a good comment about what's going on here.