-----Original Message----- From: Detlev Zundel [mailto:dzu@denx.de] Sent: 04 July 2012 13:38 To: Valentin Longchamp Cc: Prafulla Wadaskar; u-boot@lists.denx.de; holger.brunck@keymile.com Subject: Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration
Hi Valentin and Prafulla,
[...]
Dear Valentin We must keep develop it as generic driver.
Regards... Prafulla . . .
Sure it would be great if we had the time and resources to
contribute a generic
driver for these switches. Unfortunately it is not the case and we
have only
developed a simple driver with limited features that suits our
current needs.
Since we know it's very limited, we have intentionally chosen to put
in in our
board/keymile directory so that it's obvious that it is (currently)
not intended
to be used nor was it tested on other boards or with other switches.
Personally I welcome such a driver submission to mainline as it can be a starting point for someone else later.
The question now is: does u-boot allow some boards (or family of
boards) to
integrate some board codes or drivers ? It was until now our
understanding that
u-boot allows this. This code definitely fits into this category.
This is also my understanding and actually our source code has lots of them and many people are thankful to find such code (if they are able to find it ;)
As for the generic driver, if someone contributes one (the current
driver can be
used as a basis), we will be very happy to drop this code and use
the generic
driver.
Actually I would go even further and say that a generic driver can only be started when there are at least two or more users of the code. One should probably think about not making too many short-sighted assumptions when working on a driver but to think that one could develop a generic driver from one device only would be foolish.
So Prafulla, can you please reconsider to add the driver?
Hi Detlev Clear NAK for this patch
Let's put it in drivers/net/phy/ FYI: there are several drivers used by just one board, [prafulla@pe-dt061 u-boot-marvell.git (master)]$ vim drivers/net/phy/Makefile [prafulla@pe-dt061 u-boot-marvell.git (master)]$ grep -Irn "CONFIG_PHY_ATHEROS" include/configs/* include/configs/microblaze-generic.h:346:# define CONFIG_PHY_ATHEROS 1 [prafulla@pe-dt061 u-boot-marvell.git (master)]$ vim drivers/net/phy/Makefile [prafulla@pe-dt061 u-boot-marvell.git (master)]$ grep -Irn "CONFIG_PHY_BROADCOM" include/configs/* include/configs/microblaze-generic.h:347:# define CONFIG_PHY_BROADCOM 1
Anyways peripheral driver should go in drivers/
Regards... Prafulla . . .