On 24.01.2018 18:47, Alexey Brodkin wrote:
Only ARM and in some configs MIPS really implement arch_fixup_fdt(). Others just use the same boilerplate which is not good by itself, but what's worse if we try to build with disabled CONFIG_CMD_BOOTM and enabled CONFIG_OF_LIBFDT we'll hit an unknown symbol which was apparently implemented in arch/xxx/lib/bootm.c.
Now with weak arch_fixup_fdt() right in image-fdt.c where it is used we get both items highlighted above fixed.
Signed-off-by: Alexey Brodkin abrodkin@synopsys.com Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: Simon Glass sjg@chromium.org Cc: York Sun york.sun@nxp.com Cc: Stefan Roese sr@denx.de
arch/arc/lib/bootm.c | 5 ----- arch/microblaze/lib/bootm.c | 5 ----- arch/mips/lib/bootm.c | 6 ++---- arch/nds32/lib/bootm.c | 6 ------ arch/powerpc/lib/bootm.c | 5 ----- arch/sandbox/lib/bootm.c | 5 ----- arch/x86/lib/bootm.c | 5 ----- common/image-fdt.c | 5 +++++ 8 files changed, 7 insertions(+), 35 deletions(-)
Reviewed-by: Daniel Schwierzeck daniel.schwierzeck@gmail.com