Re: [U-Boot-Users] Register definition for MPC5200 WakeUp GPIO Data Input

29 Jul 2006


      In message GPECLCIGPLHEOMGPMCPAAEKKDNAA.edjubenville@adelphia.net you wrote:
...
It seems like it should have been more accurately named with a direction
suffix like this:
   #define MPC5XXX_WU_GPIO_DATA_O    (MPC5XXX_WU_GPIO + 0x000c)
   #define MPC5XXX_WU_GPIO_DATA_I    (MPC5XXX_WU_GPIO + 0x0020)
consistent with how the input/output registers for simple GPIO were named.
Agreed.
...
Renaming MPC5XXX_WU_GPIO_DATA to MPC5XXX_WU_GPIO_DATA_O would affect many
existing MPC5200-based boards.
...but is a very simple and straightforward operation.
...
Would it be better to rename MPC5XXX_WU_GPIO_DATA to MPC5XXX_WU_GPIO_DATA_O,
and modify the code for the referencing boards?
Yes.
Best regards,
Wolfgang Denk
-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
God may be subtle, but He isn't plain mean.         - Albert Einstein