On Wednesday 27 February 2008, Haavard Skinnemoen wrote:
Mike Frysinger vapier@gentoo.org wrote:
The Blackfin on-chip MAC driver was being managed in the BF537-STAMP board directory, but it is not board specific, so relocate it to the drivers dir so that other Blackfin ports can utilize it.
Signed-off-by: Mike Frysinger vapier@gentoo.org
board/bf537-stamp/Makefile | 2 +- board/bf537-stamp/ether_bf537.c | 549 --------------------------------------- board/bf537-stamp/ether_bf537.h | 71 ----- drivers/net/Makefile | 1 + drivers/net/bfin_mac.c | 523 +++++++++++++++++++++++++++++++++++++ drivers/net/bfin_mac.h | 89 +++++++ 6 files changed, 614 insertions(+), 621 deletions(-) delete mode 100644 board/bf537-stamp/ether_bf537.c delete mode 100644 board/bf537-stamp/ether_bf537.h create mode 100644 drivers/net/bfin_mac.c create mode 100644 drivers/net/bfin_mac.h
No objections from me, but I think it would be easier to review such patches if you generated them with git-format-patch -M or something similar.
thanks, i wasnt aware of that flag
That makes the patch show the actual changes to the files without all the rename noise.
in the case of the bfin_mac, the changes are minuscule: fix style in a place or two and delete dead code. -mike