Re: [U-Boot] [PATCH] I2C: mxc_i2c rework

Hello Stefano,

Stefano Babic wrote:

On 07/13/2011 11:53 AM, Marek Vasut wrote:

...

Rewrite the mxc_i2c driver.

• This version is much closer to Linux implementation.
• Fixes IPG_PERCLK being incorrectly used as clock source
• Fixes behaviour of the driver on iMX51
• Clean up coding style a bit ;-)

Signed-off-by: Marek Vasut marek.vasut@gmail.com

Hi Marek,

I have added Heiko in CC. He is the Maintainer for I2C.

Thanks! ;-)

[...]

...

+/*

• • Write register address
• */

+int i2c_imx_set_reg_addr(uint addr, int alen) {

• int i, retry = 0;
• for (retry = 0; retry < 3; retry++) {

• if (wait_idle())
  

• int ret;
• int i;

mmmhh...it seems to me you change completely the logic here. Heiko, waht do you think about ?

I think this is OK, because of calling i2c_imx_trx_complete() later, which do this ...

bye, Heiko