Re: [U-Boot-Users] [PATCH] Removed compiler issue (invalid lvalue) - CPU PXA270

stefano babic <sbabic <at> denx.de> writes:

Code is broken for PXA270 due to "invalid lvalue in assignment".

This patch fix it in pxa-regs.h

Signed-off-by: Stefano Babic <sbabic <at> denx.de>

This Patch makes wrong calculation!

The real bug can be fixed by using the old style with pointer / address (from the linux kernel)

#define GPLR(x) (*((((x) & 0x7f) < 96) ? &_GPLR(x) : &GPLR3))

or by fixing the calculation

#define GPLR(x) __REG2(0x40E00000, (((x) & 0x7f) < 96) ? ((x) & 0x60) >> 3 : 0x100)

Which is the preferred way?

Stefan