9 Nov
2015
9 Nov
'15
4:21 p.m.
On Monday, November 09, 2015 at 04:16:37 PM, Stephen Warren wrote:
On 11/09/2015 02:03 AM, Ye.Li wrote:
All the i.MX6, i.MX23 and i.MX28 OTG controllers only support UTMI interface. Set to ULPI is not correct, even the controller will reject this setting in PORTSC register.
diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c
@@ -1018,18 +1018,10 @@ int usb_gadget_register_driver(struct usb_gadget_driver *driver)
return ret;ret = ci_udc_probe();
...
if (ret) {
DBG("udc probe failed, returned %d\n", ret);return ret;}
The indentation of the "if" line is incorrect.
I'm also not quite fond of the DBG() statement, why not change it to plain debug() ?
Best regards, Marek Vasut